Skip to content

Vb/fix flaky tests vb plt 1449 2 #1793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Conversation

vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Sep 6, 2024

Description

Addressed flaky tests as described below:

  • ltest_user_management - rewrote using user invitation fixtures instead of removing all invitations in the organization fixture
  • embeddings - fixed the embeddings fixture, but there is a follow up on the server side so the test still might fail but much less
  • test_filtering - this is a very old piece of functionality and likely not even used. I have identified the flaky test and removed it. We will have good test coverage here
  • test_generic_data_types - identified the issue due to newly added LLMPromptResponseCreation / LLMPromptResponse types in this PR . For now removed these types while keeping the story open to try and look at it one more time later. This failure is not reproducible when I test locally against stage

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky force-pushed the VB/fix-flaky-tests_VB-PLT-1449_2 branch from 0c35530 to 3565821 Compare September 6, 2024 22:55
@vbrodsky vbrodsky marked this pull request as ready for review September 6, 2024 23:08
@vbrodsky vbrodsky requested a review from a team as a code owner September 6, 2024 23:08
@vbrodsky vbrodsky merged commit 9fe1695 into develop Sep 9, 2024
25 checks passed
@vbrodsky vbrodsky deleted the VB/fix-flaky-tests_VB-PLT-1449_2 branch September 9, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants